On Tue, 6 Aug 2013 10:53:01 +0000 Caizhiyong <caizhiy...@huawei.com> wrote:
> > -----Original Message----- > > From: Andrew Morton [mailto:a...@linux-foundation.org] > > Sent: Tuesday, August 06, 2013 6:22 AM > > To: Caizhiyong > > Cc: Karel Zak; linux-kernel@vger.kernel.org; Wanglin (Albert); Quyaxin; > > Jens Axboe; > > David Woodhouse; Marius Groeger > > Subject: Re: [PATCH] block: support embedded device command line partition > > > > On Sat, 3 Aug 2013 09:57:04 +0000 Caizhiyong <caizhiy...@huawei.com> wrote: > > > > > From: Cai Zhiyong <caizhiy...@huawei.com> > > > > > > Read block device partition table from command line. > > > The partition used for fixed block device (eMMC) embedded device. > > > It is no MBR, save storage space. Bootloader can be easily accessed by > > > absolute address of data on the block device. > > > Users can easily change the partition. > > > > > > This code reference MTD partition, source "drivers/mtd/cmdlinepart.c" > > > About the partition verbose reference > > "Documentation/block/cmdline-partition.txt" > > > > > > > Seems OK to me. > > > > The obvious question is: can we consolidate this with > > drivers/mtd/cmdlinepart.c in some fashion so the kernel doesn't have > > two parsers which do the same thing? > > I will move the parser to "lib/cmdline.c". > block/cmdline.c is an appropriate place for block-subsystem library code. But simply moving the file doesn't achieve anything. To prove that the code is indeed library-style code, we should actually *use* it in some client code. Such as MTD! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
