Hi,
On 08/06/2013 09:53 PM, Fabian Vogt wrote:
> This driver supports the GPIO controller found in LSI ZEVIO SoCs.
> It has been successfully tested on a TI nspire CX calculator.
> ---
> .../devicetree/bindings/gpio/gpio-zevio.txt | 19 ++
> drivers/gpio/Kconfig | 7 +
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-zevio.c | 212
> +++++++++++++++++++++
> 4 files changed, 239 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> create mode 100644 drivers/gpio/gpio-zevio.c
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> new file mode 100644
> index 0000000..96d948b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> @@ -0,0 +1,19 @@
> +Zevio GPIO controller
> +
> +Required properties:
> +- compatible = "lsi,zevio-gpio"
> +- reg = <BASEADDR SIZE>
> +- #gpio-cells = <2>
> +- gpio-controller;
> +
> +Optional:
> +- #ngpios = <32>: Number of GPIOs. Defaults to 32 if absent
> +
> +Example:
> + gpio: gpio@90000000 {
> + compatible = "lsi,zevio-gpio";
> + reg = <0x90000000 0x1000>;
> + <tab> here and I can't see the reason to have this blank line here. > + gpio-controller; > + #gpio-cells = <2>; > + }; > \ No newline at end of file Doesn't look right. > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index b2450ba..ba8c357 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -138,6 +138,13 @@ config GPIO_EP93XX > depends on ARCH_EP93XX > select GPIO_GENERIC > > +config GPIO_ZEVIO > + bool "LSI ZEVIO SoC memory mapped GPIOs" > + depends on ARCH_NSPIRE > + select GENERIC_IRQ_CHIP > + help > + Say yes here to support the GPIO controller in LSI ZEVIO SoCs. > + Not sure how subsystem maintainer handle this but I would prefer to keep this sorted as it is done in Makefile. > config GPIO_MM_LANTIQ > bool "Lantiq Memory mapped GPIOs" > depends on LANTIQ && SOC_XWAY > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile > index ef3e983..1e7e926 100644 > --- a/drivers/gpio/Makefile > +++ b/drivers/gpio/Makefile > @@ -87,3 +87,4 @@ obj-$(CONFIG_GPIO_WM831X) += gpio-wm831x.o > obj-$(CONFIG_GPIO_WM8350) += gpio-wm8350.o > obj-$(CONFIG_GPIO_WM8994) += gpio-wm8994.o > obj-$(CONFIG_GPIO_XILINX) += gpio-xilinx.o > +obj-$(CONFIG_GPIO_ZEVIO) += gpio-zevio.o > \ No newline at end of file ditto. The patch contains several trailing whitespace reported by checkpatch.pl which should be fixed. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
