On Wed 07-08-13 09:44:42, Lothar Waßmann wrote: > Hi, > > commit 0ce6966b "watchdog: update watchdog_tresh properly" breaks > build on non-SMP systems (more specifically: on systems where > CONFIG_USE_GENERIC_SMP_HELPERS is not set): > linux-next/kernel/watchdog.c: In function 'update_timers': > linux-next/kernel/watchdog.c:522:2: error: implicit declaration of function > '__smp_call_function_single' [-Werror=implicit-function-declaration]
The fix is already in the Andrew's tree so it should show up in linux-next sometimes soon. Sorry about the hassles. > I guess the offending code should be guarded by an > '#ifdef CONFIG_USE_GENERIC_SMP_HELPERS' > like in kernel/softirq.c: > #ifdef CONFIG_USE_GENERIC_SMP_HELPERS > [...] > static int __try_remote_softirq(struct call_single_data *cp, int cpu, int > softirq) > { > if (cpu_online(cpu)) { > cp->func = remote_softirq_receive; > cp->info = &softirq; > cp->flags = 0; > > __smp_call_function_single(cpu, cp, 0); > return 0; > } > return 1; > } > #else /* CONFIG_USE_GENERIC_SMP_HELPERS */ > static int __try_remote_softirq(struct call_single_data *cp, int cpu, int > softirq) > { > return 1; > } > #endif > > > Lothar Waßmann > -- > ___________________________________________________________ > > Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen > Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 > Geschäftsführer: Matthias Kaussen > Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 > > www.karo-electronics.de | i...@karo-electronics.de > ___________________________________________________________ -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/