On Fri, 2013-08-02 at 17:49 +0000, Dan Williams wrote:
>
> On 7/31/13 7:28 AM, "Andy Shevchenko" <[email protected]>
> wrote:
>
> >On Tue, 2013-07-23 at 18:36 +0300, Andy Shevchenko wrote:
> >> The debugfs interface brought a copy of the test case parameters. This
> >>makes
> >> different set of values under /sys/module/dmatest/parameters/ and
> >> /sys/kernel/debug/dmatest/. The user might be confused by the
> >>divergence of
> >> values.
> >>
> >> The proposed solution in this patch is to make module parameters
> >>writable and
> >> remove them from the debugfs. Though we're still using debugfs to
> >>control test
> >> runner and getting results.
> >>
> >> Documentation part is updated accordingly.
> >>
> >> Signed-off-by: Andy Shevchenko <[email protected]>
> >> Suggested-by: Dan Williams <[email protected]>
> >
> >Dan, do you have any comments against this series?
> >I'd like to have this incorporated into v3.12.
>
> I like this direction, and these can go in as is.
So, could it be considered as your ACK?
If so, I think it would be better to push it early to be in time for
v3.12
> But I think with a bit
> more work we can eventually trim the Œresults' file and the
> thread_{add|get}_result infrastructure. Ideally we could move all result
> reporting to ftrace and let a module parameter control which errors are
> reported.
>
> However, unless I missed it, I don¹t see this support[1] upstream yet.
>
>
> --
> Dan
>
> [1]: https://lwn.net/Articles/432186/
>
--
Andy Shevchenko <[email protected]>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
