On Wed, May 15, 2013 at 04:46:46PM +0800, Huang Shijie wrote: > update the ecc step size when we have already get the right value. > > Signed-off-by: Huang Shijie <[email protected]> > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index 53180da..bc598e6 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -1598,6 +1598,7 @@ static int gpmi_pre_bbt_scan(struct gpmi_nand_data > *this) > /* Adjust the ECC strength according to the chip. */ > this->nand.ecc.strength = this->bch_geometry.ecc_strength; > this->mtd.ecc_strength = this->bch_geometry.ecc_strength; > + this->mtd.ecc_step = this->bch_geometry.ecc_chunk_size;
Why do you need a special case here for gpmi-nand? GPMI should be initializing nand_ecc_ctrl.size (this->ecc.size) to something meaningful instead of directly setting to 1. Then nand_base will take care of setting mtd.ecc_step. Along the same line, you shouldn't need to directly override mtd.ecc_strength here; you should be setting this->ecc.strength appropriately. I see several instances here where gpmi-nand is hacking around nand_base, rather than using its intended infrastructure. The right way seems to be to avoid nand_scan() directly but instead to use nand_scan_ident() and nand_scan_tail() separately (that's what they're exported for) so that you can initialize any geometry-related options before nand_scan_tail() does the last steps. In the end, you shouldn't be needing to override this->scan_bbt at all, since you really intend to use the default implementation; you just are doing this to hack around your issues. In fact, I think every use of nand_default_bbt() outside of nand_base is a design mistake. > this->mtd.bitflip_threshold = this->bch_geometry.ecc_strength; > > /* NAND boot init, depends on the gpmi_set_geometry(). */ > Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
