>> +static int should_we_balance(struct lb_env *env)
>> +{
>> + struct sched_group *sg = env->sd->groups;
>> + struct cpumask *sg_cpus, *sg_mask;
>> + int cpu, balance_cpu = -1;
>> +
>> + /*
>> + * In the newly idle case, we will allow all the cpu's
>> + * to do the newly idle load balance.
>> + */
>> + if (env->idle == CPU_NEWLY_IDLE)
>> + return 1;
>> +
>> + sg_cpus = sched_group_cpus(sg);
>> + sg_mask = sched_group_mask(sg);
>> + /* Try to find first idle cpu */
>> + for_each_cpu_and(cpu, sg_cpus, env->cpus) {
>> + if (!cpumask_test_cpu(cpu, sg_mask) || idle_cpu(cpu))
>
> Did you want to write !idle_cpu() ?
>
You are right. I made a mistake when I wrote v2 for style change.
Thanks for spotting this.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
