On 08/16/2013 07:34 AM, Alex Thorlton wrote: > +#if ARCH_HAS_USER_NOCACHE == 0 > +#define clear_user_highpage_nocache clear_user_highpage > +#endif ... > cond_resched(); > - clear_user_highpage(p, addr + i * PAGE_SIZE); > + vaddr = haddr + i*PAGE_SIZE; > + if (!ARCH_HAS_USER_NOCACHE || i == target) > + clear_user_highpage(p, vaddr); > + else > + clear_user_highpage_nocache(p, vaddr); > } > }
Is the check for !ARCH_HAS_USER_NOCACHE in there really necessary? That logic seems like it would be taken care of by that #define. Plus, if you don't check 'ARCH_HAS_USER_NOCACHE' like this, you don't need to define a value for it, and you can axe the: +#ifndef ARCH_HAS_USER_NOCACHE +#define ARCH_HAS_USER_NOCACHE 0 +#endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
