On Mon, 19 Aug 2013, Svenning Sørensen wrote: > > On 19-08-2013 13:35, Julia Lawall wrote: > > reg_base = devm_ioremap_resource(dev, r); > > if (!musb->ctrl_base) > > return -EINVAL; > > > Not really related to Julia's patch, apart from making it more obvious > > > that > > > there's a bug here. > > > I believe it is reg_base that needs to be checked, right? > > Indeed, it is all backwards. I could extend the patch, if you want. > > > I'll let Felipe decide on that, but I can't imagine any objections. > IS_ERR() is the proper test, of course :)
I've already sent a patch, in case it is useful. julia
