On Wed, 21 Aug 2013, Linus Walleij wrote:

> On Thu, Jun 6, 2013 at 2:17 PM, Lee Jones <lee.jo...@linaro.org> wrote:
> 
> > @@ -232,15 +232,6 @@ static struct of_dev_auxdata u8500_auxdata_lookup[] 
> > __initdata = {
> >         /* Requires device name bindings. */
> >         OF_DEV_AUXDATA("stericsson,db8500-pinctrl", U8500_PRCMU_BASE,
> >                 "pinctrl-db8500", NULL),
> > -       /* Requires clock name and DMA bindings. */
> 
> The comment is just wrong.
> 
> > -       OF_DEV_AUXDATA("stericsson,ux500-msp-i2s", 0x80123000,
> > -               "ux500-msp-i2s.0", &msp0_platform_data),
> 
> Look, it also adds &msp0_platform_data, which is vital.
> 
> Result after boot:
> ALSA device list:
>   No soundcards found.
> 
> Before the patch set we had audio and I kind of liked it :-)
> 
> I think you're able to set the device name as NULL though so
> we only add this platform data, try it out.

Makes sense. Although, I don't think there is a need to change the
device name. I'll just put it under the a different heading of
"Requires DMA bindings".

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to