The current implementation does not accept this sequence on a given mdio bus: register/unregister/register.
The device core framework complain about already initialized kobject struct: "kobject (df9e9848): tried to init an initialized object, something is seriously wrong." This patch replaces the device_register call with device_add in mdiobus_register and move the device struct initialization in the mdiobus_alloc_size function. Thus the device struct is only initialized once. Signed-off-by: Boris BREZILLON <b.brezil...@overkiz.com> --- drivers/net/phy/mdio_bus.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index dc92097..a256de3 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c @@ -68,6 +68,8 @@ struct mii_bus *mdiobus_alloc_size(size_t size) bus->priv = (void *)bus + aligned_size; } + device_initialize(&bus->dev); + return bus; } EXPORT_SYMBOL(mdiobus_alloc_size); @@ -151,7 +153,7 @@ int mdiobus_register(struct mii_bus *bus) bus->dev.groups = NULL; dev_set_name(&bus->dev, "%s", bus->id); - err = device_register(&bus->dev); + err = device_add(&bus->dev); if (err) { pr_err("mii_bus %s failed to register\n", bus->id); return -EINVAL; @@ -195,12 +197,12 @@ void mdiobus_unregister(struct mii_bus *bus) BUG_ON(bus->state != MDIOBUS_REGISTERED); bus->state = MDIOBUS_UNREGISTERED; - device_del(&bus->dev); for (i = 0; i < PHY_MAX_ADDR; i++) { if (bus->phy_map[i]) device_unregister(&bus->phy_map[i]->dev); bus->phy_map[i] = NULL; } + device_del(&bus->dev); } EXPORT_SYMBOL(mdiobus_unregister); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/