On Fri, Aug 23, 2013 at 5:51 PM, rui wang <[email protected]> wrote: > On 8/11/13, Yinghai Lu <[email protected]> wrote: >> During ioapic hotplug, acpi_register_ioapic will be called. >> Now for x86, that function is blank. >> Fill that will update __mp_register_ioapic to use those ioapic. >> >> Signed-off-by: Yinghai Lu <[email protected]> >> --- >> arch/x86/kernel/acpi/boot.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c >> index 5be15d1..4a5336d 100644 >> --- a/arch/x86/kernel/acpi/boot.c >> +++ b/arch/x86/kernel/acpi/boot.c >> @@ -707,16 +707,18 @@ EXPORT_SYMBOL(acpi_unmap_lsapic); >> >> int acpi_register_ioapic(acpi_handle handle, u64 phys_addr, u32 gsi_base) >> { >> - /* TBD */ >> - return -EINVAL; >> + unsigned long long id = 0; >> + >> + acpi_evaluate_integer(handle, "_UID", NULL, &id); > > We cannot assume that "_UID" is an integer. "_UID" can be either an > integer or a string. Need to consider the case when it is a string.
Yes. But do you have test case for ioapic that _UID is not integer? Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
