Hi Xie, On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote: > On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz <sa...@linux.intel.com> wrote: > > Hi Xie, > > > > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: > >> User pass platform data to device, and platform data may be > >> NULL. > > In which case do you get that ? With DT ? > > Should rtc_init fail when pdata is NULL ? > > > > You need to explain that, be it only for us to know if it's a critical > > fix or not. > > > Sorry for late response. > If pdata is NULL, the driver will fail. The question is: Why would pdata be NULL ? If there's a fundamental issue you're hiding with this patch, you probably want to fix the real problem instead.
Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
