Adding traceevent object to interface traceevent lib.

Signed-off-by: Jiri Olsa <[email protected]>
Cc: Corey Ashford <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: David Ahern <[email protected]>
---
 tools/perf/builtin-trace.c    |   5 ++-
 tools/perf/util/evsel.c       |  44 +------------------
 tools/perf/util/trace-event.c | 100 ++++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/trace-event.h |   2 +
 4 files changed, 107 insertions(+), 44 deletions(-)

diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 69a065e..defed87 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -10,6 +10,7 @@
 #include "util/strlist.h"
 #include "util/intlist.h"
 #include "util/thread_map.h"
+#include "trace-event.h"
 
 #include <libaudit.h>
 #include <stdlib.h>
@@ -422,11 +423,11 @@ static int trace__read_syscall_info(struct trace *trace, 
int id)
        sc->fmt  = syscall_fmt__find(sc->name);
 
        snprintf(tp_name, sizeof(tp_name), "sys_enter_%s", sc->name);
-       sc->tp_format = event_format__new("syscalls", tp_name);
+       sc->tp_format = trace_event__tp_format("syscalls", tp_name);
 
        if (sc->tp_format == NULL && sc->fmt && sc->fmt->alias) {
                snprintf(tp_name, sizeof(tp_name), "sys_enter_%s", 
sc->fmt->alias);
-               sc->tp_format = event_format__new("syscalls", tp_name);
+               sc->tp_format = trace_event__tp_format("syscalls", tp_name);
        }
 
        if (sc->tp_format == NULL)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 45a2a83..2076eaa 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -23,6 +23,7 @@
 #include "target.h"
 #include "perf_regs.h"
 #include "debug.h"
+#include "trace-event.h"
 
 static struct {
        bool sample_id_all;
@@ -177,47 +178,6 @@ struct perf_evsel *perf_evsel__new(struct perf_event_attr 
*attr, int idx)
        return evsel;
 }
 
-struct event_format *event_format__new(const char *sys, const char *name)
-{
-       int fd, n;
-       char *filename;
-       void *bf = NULL, *nbf;
-       size_t size = 0, alloc_size = 0;
-       struct event_format *format = NULL;
-
-       if (asprintf(&filename, "%s/%s/%s/format", tracing_events_path, sys, 
name) < 0)
-               goto out;
-
-       fd = open(filename, O_RDONLY);
-       if (fd < 0)
-               goto out_free_filename;
-
-       do {
-               if (size == alloc_size) {
-                       alloc_size += BUFSIZ;
-                       nbf = realloc(bf, alloc_size);
-                       if (nbf == NULL)
-                               goto out_free_bf;
-                       bf = nbf;
-               }
-
-               n = read(fd, bf + size, alloc_size - size);
-               if (n < 0)
-                       goto out_free_bf;
-               size += n;
-       } while (n > 0);
-
-       pevent_parse_event(NULL, &format, bf, size, sys);
-
-out_free_bf:
-       free(bf);
-       close(fd);
-out_free_filename:
-       free(filename);
-out:
-       return format;
-}
-
 struct perf_evsel *perf_evsel__newtp(const char *sys, const char *name, int 
idx)
 {
        struct perf_evsel *evsel = zalloc(sizeof(*evsel));
@@ -232,7 +192,7 @@ struct perf_evsel *perf_evsel__newtp(const char *sys, const 
char *name, int idx)
                if (asprintf(&evsel->name, "%s:%s", sys, name) < 0)
                        goto out_free;
 
-               evsel->tp_format = event_format__new(sys, name);
+               evsel->tp_format = trace_event__tp_format(sys, name);
                if (evsel->tp_format == NULL)
                        goto out_free;
 
diff --git a/tools/perf/util/trace-event.c b/tools/perf/util/trace-event.c
index a155a77..dd4ced7 100644
--- a/tools/perf/util/trace-event.c
+++ b/tools/perf/util/trace-event.c
@@ -1,6 +1,17 @@
 
+#include <stdio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <errno.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <linux/kernel.h>
 #include <traceevent/event-parse.h>
 #include "trace-event.h"
+#include "util.h"
+
+static struct trace_event tevent;
 
 int trace_event__init(struct trace_event *t)
 {
@@ -19,3 +30,92 @@ void trace_event__cleanup(struct trace_event *t)
        pevent_free(t->pevent);
        traceevent_unload_plugins(t->plugin_list);
 }
+
+static char *debugfs__get_file(const char *file, size_t *sizep)
+{
+       size_t size = 0, alloc_size = 0;
+       void *bf = NULL, *nbf;
+       int fd, n;
+
+       fd = open(file, O_RDONLY);
+       if (fd < 0)
+               return NULL;
+
+       do {
+               if (size == alloc_size) {
+                       alloc_size += BUFSIZ;
+                       nbf = realloc(bf, alloc_size);
+                       if (!nbf)
+                               goto out_failed;
+
+                       bf = nbf;
+               }
+
+               n = read(fd, bf + size, BUFSIZ);
+               if (n < 0)
+                       goto out_failed;
+
+               size += n;
+       } while (n > 0);
+
+       *sizep = size;
+
+       close(fd);
+       return bf;
+
+ out_failed:
+       free(bf);
+       close(fd);
+       return NULL;
+}
+
+static char *get_tracepoint_format(const char *sys, const char *name,
+                                  size_t *size)
+{
+       char path[PATH_MAX];
+
+       scnprintf(path, PATH_MAX, "%s/%s/%s/format",
+                 tracing_events_path, sys, name);
+
+       return debugfs__get_file(path, size);
+}
+
+static struct event_format*
+tp_format(const char *sys, const char *name)
+{
+       struct pevent *pevent = tevent.pevent;
+       struct event_format *event = NULL;
+       size_t size;
+       char *data;
+
+       data = get_tracepoint_format(sys, name, &size);
+       if (!data)
+               return NULL;
+
+       pevent_parse_event(pevent, &event, data, size, sys);
+
+       free(data);
+       return event;
+}
+
+struct event_format*
+trace_event__tp_format(const char *sys, const char *name)
+{
+       static bool initialized;
+
+       if (!initialized) {
+               int be = traceevent_host_bigendian();
+               struct pevent *pevent;
+
+               if (trace_event__init(&tevent))
+                       return NULL;
+
+               pevent = tevent.pevent;
+               pevent_set_flag(pevent, PEVENT_NSEC_OUTPUT);
+               pevent_set_file_bigendian(pevent, be);
+               pevent_set_host_bigendian(pevent, be);
+               initialized = true;
+       }
+
+       return tp_format(sys, name);
+}
diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h
index c099879..62b0fda 100644
--- a/tools/perf/util/trace-event.h
+++ b/tools/perf/util/trace-event.h
@@ -18,6 +18,8 @@ struct trace_event {
 
 int trace_event__init(struct trace_event *t);
 void trace_event__cleanup(struct trace_event *t);
+struct event_format*
+trace_event__tp_format(const char *sys, const char *name);
 
 int bigendian(void);
 
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to