Kyle McMartin <k...@infradead.org> writes: > On Fri, Sep 06, 2013 at 07:51:18PM +0200, Frantisek Hrbata wrote: >> > > v2: - reuse mod->ctors for .init_array section for modules, because gcc >> > > uses >> > > .ctors or .init_array, but not both at the same time >> > > >> > > Signed-off-by: Frantisek Hrbata <fhrb...@redhat.com> >> > >> > Might be nice to document which gcc version changed this, so people can >> > choose whether to cherry-pick this change? >> >> Thank you for pointing this out. As per gcc git this was introduced by commit >> ef1da80 and released in 4.7 version. >> >> $ git describe --contains ef1da80 >> gcc-4_7_0-release~4358 >> >> Do you want me to post v3 with this info included in the descrition? >> > > It actually depends on the combination of binutils/ld and gcc you use, not > simply which gcc version you use. :/
Indeed, and seems it was binutils 20110507 which actually handled it properly. AFAICT it's theoretically possible to have .ctors and .init_array in a module. Unlikely, but the patch should check for both and refuse to load the module in that case. Otherwise weird things would happen. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
