On Fri, 06 Sep 2013, Stephen Warren wrote: > From: Stephen Warren <swar...@nvidia.com> > > rtc-tps6586x calls enable/disable_irq_wake() during suspend/resume. Since > the main tps6586x irq_chip doesn't implement .irq_set_wake, this causes > the RTC's enable_irq_wake() to fail, and the disable_irq_wake() to spew a > WARN about unbalanced wake disable. Solve this by implementing > .irq_set_wake. > > Also, I assume that enable_irq_wake() shouldn't be called unconditionally > in tps6586x_irq_init(), since this is now triggered by IRQ children > setting up their cascaded IRQs for wake. So, remove that. > > Signed-off-by: Stephen Warren <swar...@nvidia.com> > --- > I'm tempted to Cc stable here, since this bug is certainly present in > older kernel releases. However, the only user-visible aspect is the WARN > on resume, so I'm not sure if it's worth it?
Can't do any harm? > --- > drivers/mfd/tps6586x.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) Patch applied. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
