On Mon, Sep 9, 2013 at 1:01 PM, Heiko Carstens <heiko.carst...@de.ibm.com> wrote: > On Sun, Sep 08, 2013 at 07:31:18PM -0700, Guenter Roeck wrote: >> On 09/08/2013 07:31 PM, Greg Kroah-Hartman wrote: >> >On Sun, Sep 08, 2013 at 07:24:19PM -0700, Guenter Roeck wrote: >> >>On 09/08/2013 06:59 PM, Greg Kroah-Hartman wrote: >> >>>On Sun, Sep 08, 2013 at 06:03:00PM -0700, Guenter Roeck wrote: >> >>>>mips allmodconfig fails with >> >>>> >> >>>>ERROR: "copy_from_user_page" >> >>>>[drivers/staging/lustre/lustre/libcfs/libcfs.ko] >> >>>>undefined! >> >>>> >> >>>>which is due to LUSTRE using copy_from_user_page which is not exported >> >>>>by any >> >>>>architecture. >> >>> >> >>>Any, or just these arches? >> >>> >> >>Other architectures implement it as define as far as I can see. >> > >> >Then why would it be a problem? >> > >> It isn't a problem for those other architectures. Mostly it is mapped to >> functions like memcpy(). >> >> Guenter >> >> >>>>Unfortunately, LUSTRE can only be built as module, so there is no >> >>>>easy fix. >> >>> >> >>>Can't we just export the functions for those arches? Surely lutre >> >>>isn't the first/only driver that needs this? >> >>> >> >>That would be another option. >> >> >> >>Actually, turns out Geert submitted a patch to do this for mips already, >> >>and Ralf applied it: >> >> >> >>https://lkml.org/lkml/2013/9/5/111 >> >> >> >>So please forget this patch. If sh/xtensa actually need it, we can do the >> >>same there. >> > >> >Sounds good to me, consider it forgotten :) >> > >> >greg k-h > > The proper "fix" seems to be to get rid of this new usage of > copy_from_user_page() in lustre. > The code in question is nothing but a copy of __access_remote_vm() > from mm/memory.c... > The problem is access_process_vm() is not exported since certain version of kernel including the latest. According to Christoph in the other mail, access_process_vm() is also a core mm function that is not supposed to be exported. Then what kind of change shall we make in order to keep current functionality?
Thanks, Bergwolf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
