On 09/11/2013 11:16 AM, Guenter Roeck wrote:
>
> Signed-off-by: Guenter Roeck <li...@roeck-us.net>
> ---
> v2: rephrase patch subject
> call gpio_set_debounce before registering extcon device,
> and set debounce_jiffies only if the call was not successful
>
> drivers/extcon/extcon-gpio.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c
> index 77d35a7..e5a4405 100644
> --- a/drivers/extcon/extcon-gpio.c
> +++ b/drivers/extcon/extcon-gpio.c
> @@ -100,7 +100,13 @@ static int gpio_extcon_probe(struct platform_device
> *pdev)
> extcon_data->state_off = pdata->state_off;
> if (pdata->state_on && pdata->state_off)
> extcon_data->edev.print_state = extcon_gpio_print_state;
> - extcon_data->debounce_jiffies = msecs_to_jiffies(pdata->debounce);
> + if (pdata->debounce) {
> + ret = gpio_set_debounce(extcon_data->gpio,
> + pdata->debounce * 1000);
> + if (ret < 0)
> + extcon_data->debounce_jiffies =
> + msecs_to_jiffies(pdata->debounce);
> + }
>
> ret = extcon_dev_register(&extcon_data->edev, &pdev->dev);
> if (ret < 0)
>
I'd like you to add patch description for patch feature.
So I add a little description about using gpio_set_debounce()
I modify patch name as following to maintain patch naming style of extcon.
Before
extcon-gpio: Do not unnecessarily initialize variables
extcon-gpio: Use gpio driver/chip debounce if supported
After
extcon: gpio: Do not unnecessarily initialize variables
extcon: gpio: Use gpio driver/chip debounce if supported
Applied it on extcon-linus.
You can check it on extcon-linus branch in a few minutes.
Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
