Hi Jens, Here is patch which takes care of removal of unused readq / readl function. I shall get rid of many VPRINTKs in the code in the subsequent patches.
I have prepared this patch on top of earlier patch I had sent out. Please let me know if you have any comments. Thank you. -------------- >From 0c175433db8079e93890ebfcd736fa8756aa88af Mon Sep 17 00:00:00 2001 From: Akhil Bhansali <[email protected]> Date: Thu, 19 Sep 2013 17:28:18 +0530 Subject: [PATCH] block: skd: Changes to remove unused readq / readl function calls. These changes are to remove readq functions which is not used. Signed-off-by: Akhil Bhansali <[email protected]> --- drivers/block/skd_main.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 0f25830..4c03b08 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -421,14 +421,10 @@ static inline void skd_reg_write32(struct skd_device *skdev, u32 val, if (likely(skdev->dbg_level < 2)) { writel(val, skdev->mem_map[1] + offset); barrier(); - readl(skdev->mem_map[1] + offset); - barrier(); } else { barrier(); writel(val, skdev->mem_map[1] + offset); barrier(); - readl(skdev->mem_map[1] + offset); - barrier(); VPRINTK(skdev, "offset %x = %x\n", offset, val); } } @@ -439,14 +435,10 @@ static inline void skd_reg_write64(struct skd_device *skdev, u64 val, if (likely(skdev->dbg_level < 2)) { writeq(val, skdev->mem_map[1] + offset); barrier(); - readq(skdev->mem_map[1] + offset); - barrier(); } else { barrier(); writeq(val, skdev->mem_map[1] + offset); barrier(); - readq(skdev->mem_map[1] + offset); - barrier(); VPRINTK(skdev, "offset %x = %016llx\n", offset, val); } } -- ________________________________________ From: Jens Axboe [[email protected]] Sent: Wednesday, September 18, 2013 8:06 PM To: Akhil Bhansali Cc: kbuild test robot; OS Engineering; Ramprasad Chinthekindi; [email protected]; [email protected]; Amit Phansalkar Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq' On Wed, Sep 18 2013, Akhil Bhansali wrote: > Hi Jens, > > Please accept this patch that takes care of warnings related to i386 > compilation. > 1. Implicit function declaration of readq and writeq. > 2. Format related warnings for VPRINTK. You should get rid of the VPRINTK() as well, we do have debug facilities in place you can use for printing. And as mentioned a week or so ago, readq() isn't even used. -- Jens Axboe PROPRIETARY-CONFIDENTIAL INFORMATION INCLUDED This electronic transmission, and any documents attached hereto, may contain confidential, proprietary and/or legally privileged information. The information is intended only for use by the recipient named above. If you received this electronic message in error, please notify the sender and delete the electronic message. Any disclosure, copying, distribution, or use of the contents of information received in error is strictly prohibited, and violators will be pursued legally. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
