On Fri, Sep 20, 2013 at 12:47:32PM -0400, Dave Jones wrote: > Probably harmless, but still not a nice thing to do. > > Signed-off-by: Dave Jones <[email protected]> > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 368a4d5..75d3556 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct > file *filp) > if (ret < 0) { > trace_array_put(tr); > kfree(dir); > + dir = NULL; > } > > filp->private_data = dir;
Er... Why not simply return ret; instead? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
