On Tue, Sep 24, 2013 at 09:17:16PM +0800, Zhang Yanfei wrote: > > Maybe just print warning only on the first failure? > > Hmmm... This message is for each memblock allocation, that said, if the > allocation this time fails, it prints the message and we use so called > top-down. > But next time, we still use bottom up first again. > > Did you mean if we fail on one bottom-up allocation, then we never try > bottom-up again and will always use top-down?
Nope, it's just that it might end up printing something for each alloc which can end up flooding console / log. The first failure is the most interesting and pretty much defeats the purpose of the whole thing after all. If it's expected to fail very rarely, I'd just stick in WARN_ONCE() there as the stack trace would be interesting too. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
