On 25 September 2013 13:32, Jingoo Han <jg1....@samsung.com> wrote:
> Use devm_regulator_register() to make cleanup paths simpler.

>  static int lp3972_i2c_remove(struct i2c_client *i2c)
>  {
>         struct lp3972 *lp3972 = i2c_get_clientdata(i2c);
> -       int i;
>
> -       for (i = 0; i < lp3972->num_regulators; i++)
> -               regulator_unregister(lp3972->rdev[i]);
>         kfree(lp3972->rdev);

With devm the unregister would happen after the freeing of the device.
Wouldn't this re-ordering cause any
problems?

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to