> Of course, since then, we may well have screwed things up and now we > sleep under it, but I still really think it was a mistake to do it in > the first place. > > So if the primary reason for this is really just that f*cking anon_vma > lock, then I would seriously suggest: > > - turn it back into a spinlock (or rwlock_t, since we subsequently > separated the read and write paths)
Yes please. spinlocks/rwlocks have so much nicer performance behavior than rwsems/mutexes (which noone seems to fully understand) We had also significant performance regressions from every such spinning->sleeping change in the VM (this was just the latest) And afaik anon_vma is usually hold short. -Andi -- a...@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/