On Wed, Sep 25, 2013 at 04:33:24PM +0200, Daniel Lezcano wrote: > On 09/16/2013 11:44 AM, Uwe Kleine-König wrote: > > Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> > > --- > > Hello, > > > > I'm not sure that the way I implemented if a given timer is used as > > clock_source or clock_event_device is robust. Does it need locking? > > The reason to create a timer device for each timer instead of a single > > device of all of them is that it makes it cleaner to specify irqs and > > clks which each timer has one of each respectively. I didn't find an > > example, but while looking I wondered if in zevio-timer.c a single timer > > can really support both clock_event and clocksource. > > > > I guess for inclusion I need to write a document describing the > > of-binding. I will include that in the next iteration. > > Right and a nice description of the timer would be valuable. Where is the location to put a device tree binding document for a clocksource/clock event device? I found
arm,armv7-timer-mem | arm/arch_timer.txt fsl,timrot | N/A nvidia,tegra20-rtc | rtc/nvidia,tegra20-rtc.txt Should I introduce a "clocksource" directory below Documentation/devicetree/bindings? Other than that if there are no further comments I'll sent a v2 soon. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/