On 10/1/13 1:16 AM, Ingo Molnar wrote:
Just a detail: it would be nice to make all the user facing messages in
tools/perf/util/header.c more specific and more structured. For example
prefixing it with 'perf header:' would be fine:

        WARNING: perf/header: Data size is 0. Was the 'perf record' command 
properly terminated?


Why put code references in the messages? The message is all on one line so grep finds it quickly for people working on the code.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to