On 01-10-2013 18:51, Nishanth Menon wrote: > On 14:32-20131001, Eduardo Valentin wrote: >> On dra7-evm there is an tmp102 temperature sensor on i2c bus 1. >> This patch adds its device tree node. >> >> Signed-off-by: Eduardo Valentin <eduardo.valen...@ti.com> >> --- >> arch/arm/boot/dts/dra7-evm.dts | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts >> index 21fe16b..3b6c16a 100644 >> --- a/arch/arm/boot/dts/dra7-evm.dts >> +++ b/arch/arm/boot/dts/dra7-evm.dts >> @@ -7,6 +7,8 @@ >> */ >> /dts-v1/; >> >> +#include <dt-bindings/thermal/thermal.h> >> + > > ^^ needed?
In fact this is left over from previous local versions and can be
removed from this patch.
However, depending on how patch 7 evolves, it could be needed, yes.
>
>> #include "dra7.dtsi"
>>
>> / {
>> @@ -93,6 +95,12 @@
>> pinctrl-names = "default";
>> pinctrl-0 = <&i2c1_pins>;
>> clock-frequency = <400000>;
> could you add an EOL here?
>> + tmp102: tmp102@48{
> a space before the {?
ok for both cosmetic comments.
>> + compatible = "ti,tmp102";
>> + reg = <0x48>;
>> +
>> + #thermal-sensor-cells = <0>;
>> + };
>> };
>>
>> &i2c2 {
>> --
>> 1.8.2.1.342.gfa7285d
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
>> the body of a message to majord...@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
You have got to be excited about what you are doing. (L. Lamport)
Eduardo Valentin
signature.asc
Description: OpenPGP digital signature
