On Thu, Oct 03, 2013 at 03:22:51AM +0100, Al Viro wrote:
> > + /*
> > + * Link the inode to a directory entry by creating a unique name
> > + * using the inode sequence number.
> > + */
> > + file = ERR_PTR(-ENOMEM);
> > + this.name = name;
> > + this.len = strlen(name);
> > + this.hash = 0;
>
> Umm... ITYM
> struct qstr this = QSTR_INIT("[aio]", 5);
> , if not
> path.dentry = d_alloc_pseudo(aio_mnt->mnt_sb,
> &(struct qstr)QSTR_INIT("[aio]", 5));
> > + if (!path.dentry)
> > + goto err_module;
and you've leaked that inode, BTW.
Another thing: I'd rather pull everything about setting the inode
up (aops, size, etc.) in there.
Anyway, could you take a look at the last couple of commits in
vfs.git#for-bcrl? Commit message on the last one is an atrocity,
of course...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
