Hi
a comment on this one (and any similar patch)
On 10/03/2013 08:56 AM, Viresh Kumar wrote:
__cpuidle_get_cpu_driver() is a single line function and so deserves to be
marked inline.
In general, this is a violation of Documentation/CodingStyle - see
Chapter 15.
Unless this produces a significant benefit, it's probably best to just
let the compiler do this if it wants.
- Paul
Acked-by: Daniel Lezcano <daniel.lezc...@linaro.org>
Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org>
---
drivers/cpuidle/driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c
index ced1df6..25455e8 100644
--- a/drivers/cpuidle/driver.c
+++ b/drivers/cpuidle/driver.c
@@ -29,7 +29,7 @@ static DEFINE_PER_CPU(struct cpuidle_driver *,
cpuidle_drivers);
* Returns a pointer to struct cpuidle_driver or NULL if no driver has been
* registered for @cpu.
*/
-static struct cpuidle_driver *__cpuidle_get_cpu_driver(int cpu)
+static inline struct cpuidle_driver *__cpuidle_get_cpu_driver(int cpu)
{
return per_cpu(cpuidle_drivers, cpu);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
