On Fri, Oct 04, 2013 at 11:16:20AM +0200, Michal Simek wrote:
> On 10/04/2013 07:33 AM, Wolfram Sang wrote:
> >
> >> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> >> + if (IS_ERR(i2c->base)) {
> >> + dev_err(&pdev->dev, "Could not allocate iomem\n");
> >
> > devm_ioremap_resource already prints error messages.
>
> you are right.
>
> >
> >> + ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
> >
> > This is too early. Can you find out why?
>
> Why do you think that it is too early?The ISR uses spinlocks which are not initialized by then. > I am looking at origin code again and I think that the code > is also problematic because in xiic_reinit() interrupts are enabled > but they are requested later. > Shouldn't be there a logic that interrupts should be enabled when > interrupts are registered by the kernel? First register the handler, then activate interrupts. You are right, this needs to be fixed, too. Regards, Wolfram
signature.asc
Description: Digital signature
