On Sat, Oct 05, 2013 at 11:51:48AM -0700, Joe Perches wrote:
> On Sat, 2013-10-05 at 11:43 -0700, Josh Triplett wrote:
> > Kernel maintainers reject new instances of the GPL boilerplate paragraph
> > directing people to write to the FSF for a copy of the GPL, since the
> > FSF has moved in the past and may do so again.
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -1859,6 +1859,16 @@ sub process {
> > $rpt_cleaners = 1;
> > }
> >
> > +# Check for FSF mailing addresses.
> > + if ($rawline =~ /You should have received a copy/ ||
>
> There are over 9,000 of these in the tree.
>
> > + $rawline =~ /write to the Free Software/ ||
>
> Over 7,000
>
> > + $rawline =~ /59 Temple Place/ ||
>
> Over 3,500
>
> > + $rawline =~ /51 Franklin Street/) {
>
> Over 1,500
And there shouldn't be any more added. (Also, case in point, note that
the FSF is no longer at "59 Temple Place".)
> > + my $herevet = "$here\n" . cat_vet($rawline) . "\n";
> > + ERROR("FSF_MAILING_ADDRESS",
> > + "Do not include the paragraph about writing to
> > the Free Software Foundation's mailing address from the sample GPL notice.
> > The FSF has changed addresses in the past, and may do so again. Linux
> > already includes a copy of the GPL.\n" . $herevet)
>
> Is this really a useful ERROR condition?
> Maybe a CHK --strict test or a warning instead?
How about making it a hard ERROR in patch mode, making "59 Temple Place"
an error in any mode, and making the other lines only warnings in file
mode?
Note that I made it an error because for many maintainers it's an
automatic patch rejection.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
