On Tue, 2013-10-08 at 09:10 -0700, Anatol Pomozov wrote:
> If second parameter passed to this function was 64 then it silently
> truncates to 32 bits. Catch such situation.
[]
> diff --git a/include/asm-generic/div64.h b/include/asm-generic/div64.h
[]
> @@ -25,6 +26,7 @@
>  # define do_div(n,base) ({                                   \
>       uint32_t __base = (base);                               \
>       uint32_t __rem;                                         \
> +     BUG_ON(sizeof(base) > 4 && base >= (1UL<<32));          \

I think this would be better as a BUILD_BUG_ON


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to