On Tue, 3 Jul 2001, Ken Brownfield wrote: > Somewhere between 2.4.5-pre1 and 2.4.6-pre3, the behavior of the setgid > bit on directories has changed: Fsck... Linus, please apply the patch below. That's a bug in ext2_new_inode() that used to be hidden by redundant code in ext2_mkdir(). Notice that current code in ext2_new_inode() makes no sense at all - the only reason why gcc doesn't scream bloody murder is that we have (unrelated) S_ISLNK(mode) several lines below. --- fs/ext2/ialloc.c Tue Jun 5 09:24:52 2001 +++ fs/ext2/ialloc.c.fix Tue Jul 3 05:38:37 2001 @@ -417,7 +417,6 @@ cpu_to_le32(le32_to_cpu(es->s_free_inodes_count) - 1); mark_buffer_dirty(sb->u.ext2_sb.s_sbh); sb->s_dirt = 1; - inode->i_mode = mode; inode->i_uid = current->fsuid; if (test_opt (sb, GRPID)) inode->i_gid = dir->i_gid; @@ -427,6 +426,7 @@ mode |= S_ISGID; } else inode->i_gid = current->fsgid; + inode->i_mode = mode; inode->i_ino = j; inode->i_blksize = PAGE_SIZE; /* This is the optimal IO size (for stat), not the fs block size */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/