On Tue, Oct 8, 2013 at 5:15 PM, Al Viro <v...@ftp.linux.org.uk> wrote:
>
> ... and deal with short writes properly
.. except you don't.
> + while (nr) {
> + if (dump_interrupted())
> + return 0;
> + n = vfs_write(file, addr, nr, &pos);
> + if (n < 0)
> + return 0;
> + file->f_pos = pos;
> + cprm->written += n;
> + nr -= n;
> + }
Please handle 'n == 0' too. Maybe it never happens (ie you get EPIPE
or ENOSPC), but write returning zero is actually possible and a valid
return value and traditional for "end of media". Looping forever is
not a good idea.
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
