On Wed, Oct 09, 2013 at 02:29:20PM -0700, Paul E. McKenney wrote: > Hello! > > This series features updates to allow sparse to do a better job of > statically analyzing RCU usage: > > 1. Apply ACCESS_ONCE() to rcu_assign_pointer()'s target to prevent > comiler mischief. Also require that the source pointer be from > the kernel address space. Sometimes it can be from the RCU address > space, which necessitates the remaining patches in this series. > Which, it must be admitted, apply to a very small fraction of > the rcu_assign_pointer() invocations in the kernel. This commit > courtesy of Josh Triplett. > > 2-13. Apply rcu_access_pointer() to avoid a number of false positives.
I posted one minor nit in response to one of these patches, but in any case, for 2-13: Reviewed-by: Josh Triplett <j...@joshtriplett.org> I'm obviously OK with patch 1 as well, but it should move to the end of the series, and you need a new patch 1 that adds a comment constraining rcu_assign_pointer to evaluate its argument exactly once. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
