On 10/11/2013 03:15 PM, Rhyland Klein wrote: > From: Darbha Sriharsha <dsrihar...@nvidia.com> > > Adds support for the bq24735 charger chipset. The bq24735 is a > high-efficiency, synchronous battery charger. > > It allows control of the charging current, input current, and the charger > voltage DAC's through SMBus.
Please CC the DT bindings maintainers on patches that add DT bindings. > diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt > b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt > +Optional properties : > + - ti,ac-detect-gpios : This GPIO is optionally used to read the AC adapter > + presence. Is that actually a property of the BQ24735 chip itself (i.e. is it an output signal from the chip), or part of the board/system? Aside from that, the binding looks reasonable to me (although I'm no longer a DT bindings maintainer). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
