On 10/15/2013 08:52 AM, Peter De Schrijver wrote: > Move audio clocks and PLLA initialization to a common file so it can be used > by > multiple Tegra SoCs.
> diff --git a/drivers/clk/tegra/clk-tegra114.c > b/drivers/clk/tegra/clk-tegra114.c > +static struct tegra_clk tegra114_clks[tegra_clk_max] __initdata = { > + [tegra_clk_rtc] = { .dt_id = TEGRA114_CLK_RTC, .present = true }, > + [tegra_clk_timer] = { .dt_id = TEGRA114_CLK_TIMER, .present = true }, > + [tegra_clk_uarta] = { .dt_id = TEGRA114_CLK_UARTA, .present = true }, ... > @@ -2194,7 +2167,7 @@ static void __init tegra114_clock_init(struct > device_node *np) ... > + tegra_audio_clk_init(clk_base, pmc_base, tegra114_clks, &pll_a_params); I think it's worth explaining in the commit description why an array of not-remotely-audio-related clocks is being passed into an audio-clock-initialization function. I see now that it's because not all SoCs have the same set of clocks, and this table is what tells the common audio code which clocks to actually create for this SoC, but that wasn't obvious, and hence should be explicitly described. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/