On Thu, Oct 17, 2013 at 07:37:45AM +0530, Vinod Koul wrote:
> index 0bc7275..683c380 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -45,16 +45,17 @@ static inline int dma_submit_error(dma_cookie_t cookie)
>
> /**
> * enum dma_status - DMA transaction status
> - * @DMA_SUCCESS: transaction completed successfully
> + * @DMA_COMPLETE: transaction completed
> * @DMA_IN_PROGRESS: transaction not yet processed
> * @DMA_PAUSED: transaction is paused
> * @DMA_ERROR: transaction failed
> */
> enum dma_status {
> - DMA_SUCCESS,
> + DMA_COMPLETE,
> DMA_IN_PROGRESS,
> DMA_PAUSED,
> DMA_ERROR,
> + DMA_SUCCESS,
> };
There are some drivers which compare against == or != DMA_SUCCESS. Shouldn't
this
become
enum dma_status {
- DMA_SUCCESS,
+ DMA_COMPLETE = 0, DMA_SUCCESS = 0,
DMA_IN_PROGRESS,
DMA_PAUSED,
DMA_ERROR,
};
so nothing breaks during the transition?
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
