On Thu, Oct 24, 2013 at 10:25:55AM +0100, Jens Axboe wrote: > blk-mq reuses the request potentially immediately, since the most > cache hot is always given out first. This means that rq->csd could > be reused between csd->func() being called and csd_unlock() being > called. This isn't a problem, since we never use wait == 1 for > the smp call function. Add CSD_FLAG_WAIT to be able to tell the > difference, retaining the warning for other cases. > > Cc: Ingo Molnar <[email protected]> > Signed-off-by: Jens Axboe <[email protected]>
Looks fine, but I'd be tempted to just delete the WARN_ON and add a comment similar to the commit message there. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
