On Sun, 2013-10-27 at 15:14 -0700, Joe Perches wrote: > On Sun, 2013-10-27 at 22:02 +0000, Ben Hutchings wrote: > > On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: > > > On Sun, 2013-10-27 at 21:50 +0000, Ben Hutchings wrote: > > > > Physical addresses may be wider than virtual addresses (e.g. on i386 > > > > with PAE) and must not be formatted with %p. > > > > > > %pa works. %pa also prefixes with 0x. > > > > Only as long as pci_resource_start() happens to be an lvalue. I'd > > rather not introduce that assumption. > > pci_resource_start returns a resource_size_t which is a phys_addr_t. > > Changing that from an lvalue would cause a _lot_ of breakage.
I don't think so. This doesn't find anything:
git grep '&[ (]*pci_resource_start'
and I was able to build drivers/{net,pci,scsi}/ successfully with
pci_resource_start() changed to an inline function.
Ben.
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
signature.asc
Description: This is a digitally signed message part
