From: Stephen Hemminger <step...@networkplumber.org> Date: Fri, 25 Oct 2013 08:41:34 -0700
> I would rather not fix the warning this way since it risks masking > later bugs if this code ever changes. But this is suboptimally coded, and is asking for the warning. Anything returning a pointer by reference is asking for trouble in my opinion. The correct thing to do is to make create_v{4,6}_sock() return the "struct socket *" as an error pointer. No more ambiguous initializations, no more warnings. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/