On Sun, 27 Oct 2013 09:34:44 -0600, David Ahern wrote: > On 10/26/13 8:25 AM, Jiri Olsa wrote: >> diff --git a/tools/perf/Documentation/perf-top.txt >> b/tools/perf/Documentation/perf-top.txt >> index c16a09e..d311974 100644 >> --- a/tools/perf/Documentation/perf-top.txt >> +++ b/tools/perf/Documentation/perf-top.txt >> @@ -143,20 +143,12 @@ Default is to monitor all CPUS. >> --asm-raw:: >> Show raw instruction encoding of assembly instructions. >> >> --G [type,min,order]:: >> +-G:: >> + Enables call-graph (stack chain/backtrace) recording. >> + >> --call-graph:: >> - Display call chains using type, min percent threshold and order. >> - type can be either: >> - - flat: single column, linear exposure of call chains. >> - - graph: use a graph tree, displaying absolute overhead rates. >> - - fractal: like graph, but displays relative rates. Each branch of >> - the tree is considered as a new profiled object. >> - >> - order can be either: >> - - callee: callee based call graph. >> - - caller: inverted caller based call graph. >> - >> - Default: fractal,0.5,callee. >> + Setup and enable call-graph (stack chain/backtrace) recording, >> + implies -g. > > implies '-G' for perf-top. Given that perf-top is recording and > analyzing events shouldn't the analysis options (caller/callee and > callgraph type) be kept here?
Yes it should, but it seems it only lived in the documentation - the -G option was already for fp or dwarf and no analyzing options. Maybe we might add --call-graph-style or something. > > Really should have callchains be consistent across perf-commands as -g. Agreed. As -g/--group option in perf top is rarely used, we maybe disable -g option for a while and then add it as a shortcut to --call-graph later. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
