On Mon, Oct 28, 2013 at 10:29:11AM -0600, Jens Axboe wrote: > It's not that I think the existing patch is THAT bad, it fits in alright > with the reserved tagging and works regardless of whether a driver uses > reserved tags or not. And it does have the upside of not requiring > special checks or logic for this special non-tagged request that using > the preallocated would might need.
The problem with it is that it will pass a tag number to the low level driver which it doesn't expect. In case the tags are used 1:1 as hardware tags that would lead to nasy bugs. At vefy least we'd need to mess with ->tag for this special request. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
