> The concern is likely/unlikely usage is proper in this code peice. > If we don't use memory isolation, the code path is used for only > MIGRATE_RESERVE which is very rare allocation in normal workload. > > Even, in memory isolation environement, I'm not sure how many > CMA/HOTPLUG is used compared to normal alloc/free. > So, I think below is more proper? > > if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { > if (is_migrate_isolate(migratetype) || is_migrate_cma(migratetype)) > > I know it's an another topic but I'd like to disucss it in this time because > we will forget such trivial thing later, again.
I completely agree with this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/