On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote: > This reorganization: > > Adds 'attrsize' variable to make the code cleaner and more > understandable, replacing all 'sizeof(attributes)'. > > Removes 'bytes' prior assignment due this new approach. > > Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'. > > Signed-off-by: Geyslan G. Bem <[email protected]> > --- > fs/efivarfs/file.c | 23 +++++++++-------------- > 1 file changed, 9 insertions(+), 14 deletions(-)
Hmm.. I'm not convinced this is much of an improvement. I think removing 'sizeof(attributes)' actually makes the code harder to read. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
