On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote: > +/* > + * Module initialization and PCIe setup. Card health monitoring and > + * recovery functionality. Character device creation and deletion are > + * controlled from here. > + * > + * Please use the new sysfs interfaces to enable the VFs after PF > + * driver loading. > + * > + * Enable VFs: > + * sudo sh -c 'echo 15 > /sys/bus/pci/devices/0000\:1b\:00.0/sriov_numvfs' > + * or > + * sudo sh -c 'echo 15 > > /sys/class/genwqe/genwqe0_card/device/sriov_numvfs' > + * Disable VFs: > + * Write a 0 into the same sysfs entries. > + */
Put this documentation somewhere a user has a _chance_ of reading it. Digging it out of code comments is not ok. Why isn't this in the ABI file for the sysfs files? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
