On 10/31, Frederic Weisbecker wrote: > > On Wed, Oct 02, 2013 at 11:11:06AM -0500, [email protected] wrote: > > --- a/arch/x86/include/asm/hw_breakpoint.h > > +++ b/arch/x86/include/asm/hw_breakpoint.h > > @@ -12,6 +12,7 @@ > > */ > > struct arch_hw_breakpoint { > > unsigned long address; > > + unsigned long mask; > > u8 len; > > So it's a bit sad that we have both len and mask.
Yes, we can probably remove it later, in fact iirc it is not strictly necessary right now. But this is minor, we can do this later and the code looks simpler this way. > thing that is actually buggy for instruction breakpoints and needs to > be sizeof(long) (who knows > what kind of fluorescent bier I drank before writing that). > > But Oleg had a patch to fix that. Yes, we already discussed some draft patches. And one of the problems was this series. I mean, the changes we discussed conflict with these patches, I think we should fix this after this series is merged. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
