This is a patch which fixes coding style issues in unioxx5.c found
by checkpatch.pl
1) Replaced printk with pr_info and pr_err
2) Reinitialized n_subd before for loop to fix over 80 character
warning
3) Reworded comment to fix 80 character warning
Signed-off-by: Conrad Gomes <conrad.s.j.go...@gmail.com>
---
drivers/staging/comedi/drivers/unioxx5.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/unioxx5.c
b/drivers/staging/comedi/drivers/unioxx5.c
index 93eec2f..de68e3a 100644
--- a/drivers/staging/comedi/drivers/unioxx5.c
+++ b/drivers/staging/comedi/drivers/unioxx5.c
@@ -96,7 +96,7 @@ static void __unioxx5_digital_config(struct unioxx5_subd_priv
*usp, int mode)
int i, mask;
mask = (mode == ALL_2_OUTPUT) ? 0xFF : 0x00;
- printk("COMEDI: mode = %d\n", mask);
+ pr_info("COMEDI: mode = %d\n", mask);
outb(1, usp->usp_iobase + 0);
@@ -185,7 +185,7 @@ static int __unioxx5_analog_read(struct unioxx5_subd_priv
*usp,
/* if four bytes readding error occurs - return 0(false) */
if ((control & Rx4CA_ERR_MASK)) {
- printk("COMEDI: 4 bytes error\n");
+ pr_err("COMEDI: 4 bytes error\n");
return 0;
}
@@ -436,8 +436,10 @@ static int unioxx5_attach(struct comedi_device *dev,
dev->iobase = iobase;
iobase += UNIOXX5_SUBDEV_BASE;
- /* defining number of subdevices and getting they types (it must be
'g01') */
- for (i = n_subd = 0, ba = iobase; i < 4; i++, ba +=
UNIOXX5_SUBDEV_ODDS) {
+ n_subd = 0;
+
+ /* getting number of subdevices with types 'g01'*/
+ for (i = 0, ba = iobase; i < 4; i++, ba += UNIOXX5_SUBDEV_ODDS) {
id = inb(ba + 0xE);
num = inb(ba + 0xF);
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
