On 11/04/2013 12:04 PM, Mel Gorman wrote: > On Tue, Oct 22, 2013 at 01:29:22PM -0400, Don Morris wrote: >> Greetings, all. >> >> Just wanted to drop this out there to see if it rang any bells. >> I've been getting a soft lockup (numad thread stuck on a cpu >> while attempting to attach a task to a cgroup) for a while now, >> but I thought it was only happening when I applied Mel Gorman's >> set of AutoNUMA patches. > > This maybe?
Certainly would make sense. My appreciation for taking a look at it. I happen to be on the road today, however -- and away from the reproduction environment. I'll give it a shot tomorrow morning and either let you know if it fixes things or report the sysrq-t output you requested. Again, my thanks! Don Morris > > ---8<--- > mm: memcontrol: Release css_set_lock when aborting an OOM scan > > css_task_iter_start acquires the css_set_lock and it must be released with > a call to css_task_iter_end. Commmit 9cbb78bb (mm, memcg: introduce own > oom handler to iterate only over its own threads) introduced a loop that > was not guaranteed to call css_task_iter_end. > > Cc: stable <[email protected]> > Signed-off-by: Mel Gorman <[email protected]> > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 5ef8929..941f67d 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1795,6 +1795,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup > *memcg, gfp_t gfp_mask, > mem_cgroup_iter_break(memcg, iter); > if (chosen) > put_task_struct(chosen); > + css_task_iter_end(&it); > return; > case OOM_SCAN_OK: > break; > . > -- kernel, n: A part of an operating system that preserves the medieval traditions of sorcery and black art. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
