Hi Ryan, Am Dienstag, den 05.11.2013, 08:55 +1100 schrieb Ryan Mallon: > On 05/11/13 04:08, Frank Haverkamp wrote: > > Selecting interface names via configuration option is obsolete. > > Don't do this. You are adding completely new code, so there is no reason > to post a patch full of code that is known to be incorrect, followed by > a set of patches fixing things. Just post the correct code to start > with. This makes the git history cleaner, and makes the code easier to > review.
Agreed. > You can use tools like git interactive rebase to split your work into > multiple patches. It should be quite easy for this because you mostly > just want to break down things to the file level, so even: > > git reset --soft <your-first-commit> > > and then manually staging and commiting things from there would probably > be enough. You can use git add --interactive to stage individual file > hunks if you want to break things down further. I have sent "Generic WorkQueue Engine (GenWQE) device driver (v6)" now which hopefully is what you wanted. Regards Frank -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/