On 11/06/2013 08:20 AM, Borislav Petkov wrote: > On Tue, Nov 05, 2013 at 09:25:52PM -0600, Rob Herring wrote: >> From: Rob Herring <rob.herr...@calxeda.com> >> >> In order to enable on arm64 and improve the build coverage, remove the >> dependency on ARCH_HIGHBANK. >> >> Signed-off-by: Rob Herring <rob.herr...@calxeda.com> >> Cc: Doug Thompson <dougthomp...@xmission.com> >> Cc: Robert Richter <r...@kernel.org> >> Cc: linux-e...@vger.kernel.org >> --- >> drivers/edac/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig >> index 878f090..fc8aaaf 100644 >> --- a/drivers/edac/Kconfig >> +++ b/drivers/edac/Kconfig >> @@ -328,14 +328,14 @@ config EDAC_TILE >> >> config EDAC_HIGHBANK_MC >> tristate "Highbank Memory Controller" >> - depends on EDAC_MM_EDAC && ARCH_HIGHBANK >> + depends on EDAC_MM_EDAC > > Please, no, this'll get enabled on other arches where this driver is > simply N/A. It should only depend on the ARM arches it supports.
Other maintainers disagree because it reduces build coverage. Having done some cross arch clean-up, I have to agree with that position. Iterating builds over different arches is bad enough, but iterating over all configs for each arch is a pain. It would be nice to have a uniform policy here. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
