[ excuse the resend, always forget that mobile-gmail sends html by default ]
On Wed, Nov 6, 2013 at 6:13 AM, Andy Shevchenko <[email protected]> wrote: > On Tue, 2013-11-05 at 11:58 -0800, Dan Williams wrote: >> On Mon, Mar 4, 2013 at 1:09 AM, Andy Shevchenko >> <[email protected]> wrote: >> > The patch provides a storage for the test results in the linked list. The >> > gathered data could be used after test is done. >> > >> > The new file 'results' represents gathered data of the in progress test. >> > The >> > messages collected are printed to the kernel log as well. >> > >> > Example of output: >> > % cat /sys/kernel/debug/dmatest/results >> > dma0chan0-copy0: #1: No errors with src_off=0x7bf dst_off=0x8ad >> > len=0x3fea (0) >> > >> > The message format is unified across the different types of errors. A >> > number in >> > the parens represents additional information, e.g. error code, error >> > counter, >> > or status. >> > >> > Note that the buffer comparison is done in the old way, i.e. data is not >> > collected and just printed out. >> > >> >> I need to revert this to get my testing done as it just leaks memory >> for no real benefit that I can see. Outside of making the log >> messages have a uniform format I'm not seeing the case for this? I'll >> revert and add a pr_fmt to make dmatest messages readily parseable. > > > The benefit of it is to access to the results asynchronously as many > times as tester wants to. > tail -f /var/log/messages is also asynchronous. > Actually I wonder where you found memory leak. It keeps the result only > for the last test run. In my test I hit the oom killer allocating the "OK" results. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
